Skip to content

Add support for build arg files in yaml format. #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

featheredtoast
Copy link
Contributor

Adds key/value yaml files as possible input for build arg file. This allows for multiline args support in from build arg files.

Since build arg file splits on newlines, it's currently not possible to do so with build arg file option: Passing yaml would allow us to set the value of build args to any string, including newlines, making this possible:

my-input/myvars.yaml

  foo: |
    first line
    second line
    third line
- task my-oci-build-task
  params:
    BUILD_ARGS_FILE: my-input/myvars.yaml
  platform: linux
  image_resource:
    type: registry-image
    source:
      repository: concourse/oci-build-task
  inputs:
    - name: my-input

setting the build arg of foo to:

first line
second line
third line

closes #122

@featheredtoast featheredtoast force-pushed the add-yaml-build-args-file branch from 9298db4 to 82e0c08 Compare September 13, 2024 16:11
Adds key/value yaml files as possible input for build arg file.

This allows for multiline args support in files.

Signed-off-by: Jeff Wong <awole20@gmail.com>
@taylorsilva taylorsilva force-pushed the add-yaml-build-args-file branch from 82e0c08 to fceb601 Compare April 15, 2025 20:50
Signed-off-by: Taylor Silva <dev@taydev.net>
Copy link
Member

@taylorsilva taylorsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the README with this feature. Thanks for the contribution and sorry for the long wait for a review.

@featheredtoast
Copy link
Contributor Author

All good, I'm glad you're able to get around to it!

@taylorsilva
Copy link
Member

Okay these checks are broken but I've run everything locally and it's all passing so I'm going to merge.

@taylorsilva taylorsilva merged commit 4203315 into concourse:master Apr 15, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option for loading build arg files from yaml, supporting dynamic multiline build args
2 participants